kbendick commented on code in PR #4943:
URL: https://github.com/apache/iceberg/pull/4943#discussion_r900351686
##########
flink/v1.15/flink/src/main/java/org/apache/iceberg/flink/FlinkConfigOptions.java:
##########
@@ -48,6 +48,8 @@
*/
public class FlinkConfigOptions {
+ public static final int MAX_SNAPSHOTS_PER_MONITOR_INTERVAL_DEFAULT = -1;
Review Comment:
I’m ok with INT_MAX if that’s what’s used elsewhere in `ScanSummary`. I
suggested -1 as we use -1 to disable cache expiration in the caching catalog
and because it’s easier to use in things like Python where INT_MAX is less
commonly used. -1 is also easier to use as in-line SQL option imo.
But if INT_MAX is already used in the `ScanSummary`, I suggest we keep that
consistent.
We can then later on consider using -1 in both places within Flink (or more
places). But consistency is better imo.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
