stevenzwu commented on code in PR #4943:
URL: https://github.com/apache/iceberg/pull/4943#discussion_r900697062
##########
flink/v1.15/flink/src/main/java/org/apache/iceberg/flink/source/StreamingMonitorFunction.java:
##########
@@ -139,7 +143,24 @@ public void run(SourceContext<FlinkInputSplit> ctx) throws
Exception {
}
}
- private void monitorAndForwardSplits() {
+ private long maxReachableSnapshotId(long lastConsumedSnapshotId, long
latestSnapshotId, int maxSnapshotCount) {
Review Comment:
nit: maybe call the args `fromSnapshotIdExclusive` and
`toSnapshotIdInclusive` to be consistent with recent incremental API naming
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
