rdblue commented on code in PR #6010:
URL: https://github.com/apache/iceberg/pull/6010#discussion_r1002159120
##########
python/pyiceberg/io/pyarrow.py:
##########
@@ -66,10 +74,14 @@ class PyArrowFile(InputFile, OutputFile):
>>> # output_file.create().write(b'foobytes')
"""
- def __init__(self, location: str, path: str, fs: FileSystem):
+ _normalized_location: NormalizedLocation
+
+ def __init__(self, location: Union[str, NormalizedLocation], fs:
FileSystem):
Review Comment:
This works, but I think it is probably cleaner to pass both `location` and
`path` into `PyArrowFile` like it was before.
The problem is that this needs to re-create the location that was passed in
to create this, rather than just passing the path directly. It also makes a few
changes in this class that are unnecessary if `PyArrowFileIO` passes location,
path, and fs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
