rdblue commented on code in PR #6010:
URL: https://github.com/apache/iceberg/pull/6010#discussion_r1013488618
##########
python/pyiceberg/io/pyarrow.py:
##########
@@ -93,11 +88,23 @@ class PyArrowFile(InputFile, OutputFile):
>>> # output_file.create().write(b'foobytes')
"""
- def __init__(self, location: str, path: str, fs: FileSystem):
+ @staticmethod
+ def normalize_path(location: str) -> str:
Review Comment:
I don't think this class needs to change at all. The file system is already
parsing the URI and can just provide the path like before.
I think you could probably argue that this class could parse the path out of
the `location` in `__init__` if the path isn't provided, but I think that's
minor.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
