Fokko commented on code in PR #6010:
URL: https://github.com/apache/iceberg/pull/6010#discussion_r1003109634
##########
python/pyiceberg/io/pyarrow.py:
##########
@@ -66,10 +74,14 @@ class PyArrowFile(InputFile, OutputFile):
>>> # output_file.create().write(b'foobytes')
"""
- def __init__(self, location: str, path: str, fs: FileSystem):
+ _normalized_location: NormalizedLocation
+
+ def __init__(self, location: Union[str, NormalizedLocation], fs:
FileSystem):
Review Comment:
Got it, I've reverted the bit and passed in the original location. I think
PyArrow itself should be responsible for handling the URL. Otherwise, users
need to construct the path when they directly initialize the PyArrow Input or
Output file. Let me know what you think of the current approach
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
