Fokko commented on code in PR #6010:
URL: https://github.com/apache/iceberg/pull/6010#discussion_r1013633552
##########
python/pyiceberg/io/pyarrow.py:
##########
@@ -223,8 +236,8 @@ def new_input(self, location: str) -> PyArrowFile:
Returns:
PyArrowFile: A PyArrowFile instance for the given location
"""
- fs, path = self.get_fs_and_path(location)
- return PyArrowFile(fs=fs, location=location, path=path)
+ fs = self.get_fs(self.extract_scheme(location))
+ return PyArrowFile(fs=fs, location=location)
Review Comment:
My main argument is that if you want to use the PyArrowFile on its own, then
the user is responsible for setting the location and path, which I think the
path should be kept internal to the object since it is a derivative of the
location.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
