aokolnychyi commented on code in PR #6107:
URL: https://github.com/apache/iceberg/pull/6107#discussion_r1012234582
##########
spark/v3.3/build.gradle:
##########
@@ -65,8 +65,9 @@
project(":iceberg-spark:iceberg-spark-${sparkMajorVersion}_${scalaVersion}") {
exclude group: 'org.apache.avro', module: 'avro'
exclude group: 'org.apache.arrow'
exclude group: 'org.apache.parquet'
- // to make sure io.netty.buffer only comes from project(':iceberg-arrow')
+ // to make sure netty libs only come from project(':iceberg-arrow')
exclude group: 'io.netty', module: 'netty-buffer'
+ exclude group: 'io.netty', module: 'netty-common'
Review Comment:
We exclude `netty-common` from many deps but not all. I feel it is safer to
be consistent.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
