RussellSpitzer commented on code in PR #6107:
URL: https://github.com/apache/iceberg/pull/6107#discussion_r1012276093
##########
spark/v3.3/build.gradle:
##########
@@ -258,7 +261,7 @@
project(":iceberg-spark:iceberg-spark-runtime-${sparkMajorVersion}_${scalaVersio
relocate 'io.airlift', 'org.apache.iceberg.shaded.io.airlift'
relocate 'org.apache.httpcomponents.client5',
'org.apache.iceberg.shaded.org.apache.httpcomponents.client5'
// relocate Arrow and related deps to shade Iceberg specific version
- relocate 'io.netty.buffer', 'org.apache.iceberg.shaded.io.netty.buffer'
+ relocate 'io.netty', 'org.apache.iceberg.shaded.io.netty'
Review Comment:
I think we should be specific about our netty modules we are relocating
here. We talked offline and ideally I wish we had a arrow distribution which
shaded netty so we wouldn't have to play this game of excluding netty
everywhere then adding back in a specific runtime version just to get the
shading correctly.
That said for now I think just being explicit will help us in the future to
remember what we are doing here 🤞
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
