aokolnychyi commented on code in PR #6107:
URL: https://github.com/apache/iceberg/pull/6107#discussion_r1012282476
##########
spark/v3.3/build.gradle:
##########
@@ -258,7 +261,7 @@
project(":iceberg-spark:iceberg-spark-runtime-${sparkMajorVersion}_${scalaVersio
relocate 'io.airlift', 'org.apache.iceberg.shaded.io.airlift'
relocate 'org.apache.httpcomponents.client5',
'org.apache.iceberg.shaded.org.apache.httpcomponents.client5'
// relocate Arrow and related deps to shade Iceberg specific version
- relocate 'io.netty.buffer', 'org.apache.iceberg.shaded.io.netty.buffer'
+ relocate 'io.netty', 'org.apache.iceberg.shaded.io.netty'
Review Comment:
The only problem is that we relocate packages. That's why I'll have to
relocate `io.netty.util` even though it comes from `netty-common`. If
`netty-common` adds classes under another package, we will miss to relocate
them.
I do agree with being more specific in relocation, though.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
