aokolnychyi commented on code in PR #6107:
URL: https://github.com/apache/iceberg/pull/6107#discussion_r1012287617
##########
spark/v3.3/build.gradle:
##########
@@ -258,7 +261,7 @@
project(":iceberg-spark:iceberg-spark-runtime-${sparkMajorVersion}_${scalaVersio
relocate 'io.airlift', 'org.apache.iceberg.shaded.io.airlift'
relocate 'org.apache.httpcomponents.client5',
'org.apache.iceberg.shaded.org.apache.httpcomponents.client5'
// relocate Arrow and related deps to shade Iceberg specific version
- relocate 'io.netty.buffer', 'org.apache.iceberg.shaded.io.netty.buffer'
+ relocate 'io.netty', 'org.apache.iceberg.shaded.io.netty'
Review Comment:
Ugh, it is really unfortunate.
If I relocate everything under `io.netty`, it won't be safe if we start
pulling netty libs from somewhere. If I relocate `io.netty.util`, nobody can
guarantee a future version of nitty-common won't have classes in another
package.
Let's probably keep the wildcard relocate as at least we are in control of
our deps.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
