rdblue commented on code in PR #6090:
URL: https://github.com/apache/iceberg/pull/6090#discussion_r1053474955
##########
core/src/main/java/org/apache/iceberg/FileCleanupStrategy.java:
##########
@@ -83,4 +85,25 @@ protected void deleteFiles(Set<String> pathsToDelete, String
fileType) {
(file, thrown) -> LOG.warn("Delete failed for {} file: {}",
fileType, file, thrown))
.run(deleteFunc::accept);
}
+
+ protected Set<String> expiredStatisticsFilesLocations(
+ TableMetadata beforeExpiration, TableMetadata afterExpiration) {
+ Set<String> statisticsFilesLocationBeforeExpiry =
allStatisticsFilesLocation(beforeExpiration);
+ Set<String> statisticsFilesLocationAfterExpiry =
allStatisticsFilesLocation(afterExpiration);
+
statisticsFilesLocationBeforeExpiry.removeAll(statisticsFilesLocationAfterExpiry);
+ return statisticsFilesLocationBeforeExpiry;
+ }
+
+ private Set<String> allStatisticsFilesLocation(TableMetadata tableMetadata) {
Review Comment:
How about `statsFileLocations` instead? Since it returns a collection, the
method name should be plural. And we also avoid needless modifiers, like `all`
(which is assumed).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
