rdblue commented on code in PR #6090:
URL: https://github.com/apache/iceberg/pull/6090#discussion_r1053482462
##########
core/src/test/java/org/apache/iceberg/TestRemoveSnapshots.java:
##########
@@ -1515,4 +1594,63 @@ private RemoveSnapshots removeSnapshots(Table table) {
RemoveSnapshots removeSnapshots = (RemoveSnapshots)
table.expireSnapshots();
return (RemoveSnapshots)
removeSnapshots.withIncrementalCleanup(incrementalCleanup);
}
+
+ private StatisticsFile writeStatsFileForCurrentSnapshot(Table table, File
statsLocation)
+ throws IOException {
+ StatisticsFile statisticsFile;
+ try (PuffinWriter puffinWriter =
Puffin.write(Files.localOutput(statsLocation)).build()) {
+ long snapshotId = table.currentSnapshot().snapshotId();
+ long snapshotSequenceNumber = table.currentSnapshot().sequenceNumber();
+ puffinWriter.add(
+ new Blob(
+ "some-blob-type",
+ ImmutableList.of(1),
+ snapshotId,
+ snapshotSequenceNumber,
+ ByteBuffer.wrap("blob
content".getBytes(StandardCharsets.UTF_8))));
+ puffinWriter.finish();
+ statisticsFile =
+ new GenericStatisticsFile(
+ snapshotId,
+ statsLocation.toString(),
+ puffinWriter.fileSize(),
+ puffinWriter.footerSize(),
+ puffinWriter.writtenBlobsMetadata().stream()
+ .map(GenericBlobMetadata::from)
+ .collect(ImmutableList.toImmutableList()));
+ }
+
+ commitStats(table, statisticsFile);
Review Comment:
Functions should not have unexpected side-effects, like committing to a
table when the expectation is to only write a file. Can you remove this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
