rdblue commented on code in PR #6090:
URL: https://github.com/apache/iceberg/pull/6090#discussion_r1053475952
##########
core/src/main/java/org/apache/iceberg/IncrementalFileCleanup.java:
##########
@@ -260,10 +260,18 @@ public void cleanFiles(TableMetadata beforeExpiration,
TableMetadata afterExpira
findFilesToDelete(manifestsToScan, manifestsToRevert, validIds,
afterExpiration);
deleteFiles(filesToDelete, "data");
- LOG.warn("Manifests to delete: {}", Joiner.on(",
").join(manifestsToDelete));
- LOG.warn("Manifests Lists to delete: {}", Joiner.on(",
").join(manifestListsToDelete));
+ LOG.debug("Manifests to delete: {}", Joiner.on(",
").join(manifestsToDelete));
+ LOG.debug("Manifests Lists to delete: {}", Joiner.on(",
").join(manifestListsToDelete));
deleteFiles(manifestsToDelete, "manifest");
deleteFiles(manifestListsToDelete, "manifest list");
+
+ if (!beforeExpiration.statisticsFiles().isEmpty()) {
+ Set<String> expiredStatisticsFilesLocations =
+ expiredStatisticsFilesLocations(beforeExpiration, afterExpiration);
+ LOG.debug(
+ "Statistics files to delete: {}", Joiner.on(",
").join(expiredStatisticsFilesLocations));
Review Comment:
What is the value of this debug message? This isn't present in the reachable
cleanup code, so I'm guessing it isn't important? If not, please remove it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
