rdblue commented on code in PR #6090:
URL: https://github.com/apache/iceberg/pull/6090#discussion_r1053487409
##########
core/src/test/java/org/apache/iceberg/TestRemoveSnapshots.java:
##########
@@ -1515,4 +1594,63 @@ private RemoveSnapshots removeSnapshots(Table table) {
RemoveSnapshots removeSnapshots = (RemoveSnapshots)
table.expireSnapshots();
return (RemoveSnapshots)
removeSnapshots.withIncrementalCleanup(incrementalCleanup);
}
+
+ private StatisticsFile writeStatsFileForCurrentSnapshot(Table table, File
statsLocation)
Review Comment:
I don't think there's a reason to pass table to this method. I think this
should accept a String location, a FileIO, and a snapshot ID.
This should also not use `File` for writing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
