jackye1995 commented on code in PR #7066:
URL: https://github.com/apache/iceberg/pull/7066#discussion_r1139252402
##########
aws/src/main/java/org/apache/iceberg/aws/AwsProperties.java:
##########
@@ -339,6 +358,12 @@ public class AwsProperties implements Serializable {
*/
public static final String CLIENT_ASSUME_ROLE_REGION =
"client.assume-role.region";
+ /**
+ * Used by {@link
org.apache.iceberg.aws.AwsClientFactories.DefaultAwsClientFactory}. If set, all
+ * AWS clients except STS client will use * the given region instead of the
default region chain.
+ */
+ public static final String AWS_CLIENT_REGION = "client.region";
Review Comment:
similar comment for variable name, should be `clientRegion` instead of
`awsRegion`, and `CLIENT_CLIENT_REGION` instead of `AWS_CLIENT_REGION`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]