noblepaul commented on a change in pull request #1109: More pervasive use of PackageLoader / PluginInfo URL: https://github.com/apache/lucene-solr/pull/1109#discussion_r361021936
########## File path: solr/core/src/java/org/apache/solr/core/TracerConfigurator.java ########## @@ -43,8 +43,7 @@ public static void loadTracer(SolrResourceLoader loader, PluginInfo info, ZkStat GlobalTracer.get().setSamplePercentage(0.0); } } else { - TracerConfigurator configurator = loader - .newInstance(info.className, TracerConfigurator.class); + TracerConfigurator configurator = loader.newInstance(info, TracerConfigurator.class); Review comment: no , thought given to reload ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org