dsmiley commented on a change in pull request #1109: More pervasive use of
PackageLoader / PluginInfo
URL: https://github.com/apache/lucene-solr/pull/1109#discussion_r361063486
##########
File path: solr/core/src/java/org/apache/solr/core/SolrResourceLoader.java
##########
@@ -529,6 +536,18 @@ public String resourceLocation(String resource) {
Class<? extends T> clazz = null;
try {
+ // If there is a package name prefix ...
+ Pair<String, String> pkgClassPair = PluginInfo.parseClassName(cname);
+ PackageLoader.Package pkg = getPackage(pkgClassPair.first());
+ if (pkg == null) {
+ // essentially, remove the package prefix and continue as normal.
Maybe it'll be found.
+ cname = pkgClassPair.second();
+ } else {
+ // TODO what version?
Review comment:
Yes, I have a "TODO" at this line. How do I get the right version?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
