dsmiley commented on a change in pull request #1109: More pervasive use of
PackageLoader / PluginInfo
URL: https://github.com/apache/lucene-solr/pull/1109#discussion_r361063126
##########
File path: solr/core/src/java/org/apache/solr/core/SolrCore.java
##########
@@ -890,7 +897,7 @@ private UpdateHandler createReloadedUpdateHandler(String
className, String msg,
}
private UpdateHandler createUpdateHandler(String className) {
- return createInstance(className, UpdateHandler.class, "Update Handler",
this, getResourceLoader());
+ return newInstance(new PluginInfo("updateHandler", className),
UpdateHandler.class, this, getResourceLoader());
Review comment:
Yes, I strongly believe hot-updates should occur in a separate ticket given
that with relative ease we can get all plugins to load via the amazing plugin
system :-)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
