dsmiley commented on a change in pull request #1109: More pervasive use of
PackageLoader / PluginInfo
URL: https://github.com/apache/lucene-solr/pull/1109#discussion_r361366578
##########
File path: solr/core/src/java/org/apache/solr/core/SolrCore.java
##########
@@ -519,7 +518,7 @@ private IndexDeletionPolicyWrapper
initDeletionPolicy(IndexDeletionPolicyWrapper
final PluginInfo info =
solrConfig.getPluginInfo(IndexDeletionPolicy.class.getName());
final IndexDeletionPolicy delPolicy;
if (info != null) {
- delPolicy = createInstance(info.className, IndexDeletionPolicy.class,
"Deletion Policy for SOLR", this, getResourceLoader());
+ delPolicy = newInstance(info, IndexDeletionPolicy.class, this,
getResourceLoader());
Review comment:
This ultimately calls SRL with PackageInfo which resolves the right package
classloader there. That's the central idea of the approach in this PR -- SRL
owns the resolution.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
