noblepaul commented on a change in pull request #1109: More pervasive use of
PackageLoader / PluginInfo
URL: https://github.com/apache/lucene-solr/pull/1109#discussion_r361234213
##########
File path: solr/core/src/java/org/apache/solr/core/SolrResourceLoader.java
##########
@@ -954,4 +987,46 @@ public static void persistConfLocally(SolrResourceLoader
loader, String resource
}
}
+ // TODO document these methods...
Review comment:
SRL has nothing to do with packages. It's an anti pattern. SRL is used by
PackageLaoder and SRL is totally agnostic of the package system. We should just
limit exposure of Packages to 2 places
- `CoreContainer` : This is where the package loader is stored
- `SolrCore` : This is where the correct version of a package for a plugin
can be identified and listeners for package updates are registered
Without the correct version, we leave the system inconsistent
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
