noblepaul commented on a change in pull request #1109: More pervasive use of
PackageLoader / PluginInfo
URL: https://github.com/apache/lucene-solr/pull/1109#discussion_r361233110
##########
File path: solr/core/src/java/org/apache/solr/core/DirectoryFactory.java
##########
@@ -420,7 +420,7 @@ static DirectoryFactory loadDirectoryFactory(SolrConfig
config, CoreContainer cc
final DirectoryFactory dirFactory;
if (info != null) {
log.debug(info.className);
- dirFactory = config.getResourceLoader().newInstance(info.className,
DirectoryFactory.class);
+ dirFactory = config.getResourceLoader().newInstance(info,
DirectoryFactory.class);
Review comment:
It's possible that we can share instances of SolrConfig between cores. We
should always use SRL from core
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
