murblanc commented on a change in pull request #1579:
URL: https://github.com/apache/lucene-solr/pull/1579#discussion_r440291350
##########
File path:
solr/solrj/src/java/org/apache/solr/client/solrj/cloud/autoscaling/Policy.java
##########
@@ -288,10 +287,11 @@ public boolean equals(Object o) {
return getClusterPreferences().equals(policy.getClusterPreferences());
}
-// @Override
-// public int hashCode() {
-// throw new UnsupportedOperationException("TODO unimplemented");
-// }
+ //TODO: Uncertain about this one
+ @Override
+ public int hashCode() {
+ return Objects.hash(zkVersion);
Review comment:
`equals()` compares `policies`, `clusterPolicy` and
`clusterPreferences`, but does not compare `zkVersion`.
`hashCode()` should not use `zkVersion` in hash computation.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
