murblanc commented on a change in pull request #1579:
URL: https://github.com/apache/lucene-solr/pull/1579#discussion_r440306014
##########
File path:
solr/solrj/src/java/org/apache/solr/common/util/ValidatingJsonMap.java
##########
@@ -348,10 +348,12 @@ public boolean equals(Object that) {
return that instanceof Map && this.delegate.equals(that);
}
-// @Override
-// public int hashCode() {
-// throw new UnsupportedOperationException("TODO unimplemented
ValidatingJsonMap.hashCode");
-// }
+ //TODO: Really uncertain about this. Hashing the map itself seems
+ // about as expensive as resolving with equals.
Review comment:
`hashCode()` and `equals()` are not used for the same type of
computations, it's not one _or_ the other, so their relative costs are not
necessarily an implementation criteria.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
