murblanc commented on a change in pull request #1579:
URL: https://github.com/apache/lucene-solr/pull/1579#discussion_r440304468
##########
File path: solr/solrj/src/java/org/apache/solr/common/cloud/ZkNodeProps.java
##########
@@ -171,8 +167,10 @@ public boolean getBool(String key, boolean b) {
public boolean equals(Object that) {
return that instanceof ZkNodeProps &&
((ZkNodeProps)that).propMap.equals(this.propMap);
}
-// @Override
-// public int hashCode() {
-// throw new UnsupportedOperationException("TODO unimplemented
ZkNodeProps.hashCode");
-// }
+
+ //TODO: I'm very uncertain about this
+ @Override
+ public int hashCode() {
+ return 0;
Review comment:
A constant `hashCode()` return value is correct but does not _spread_
objects into buckets in any useful way. Here we could return
`propMap.hashCode()` instead.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
