iverase commented on pull request #1849: URL: https://github.com/apache/lucene-solr/pull/1849#issuecomment-690067149
> It would still be interesting to know, if making BugfixDeflater_JDK8252739 public helps. I have a go locally and It does not seem to work. > while at the same time this PR was almost merged I had to stop this. I can only ensure you I was not planning in merging the PR until your review, that is the reason I added you as the only reviewer :) > One problem that was a bit confusing when @iverase opened the original issue was this sentence: "We are running into issues when running Elasticsearch CI with java security turned on." That is my bad, I will try to be more precise and assertive in the future. > Actually this bug should be visible to anybody running ES tests? 100% of all Tests should fail. It only fails in buggy JDK 11 and if you are hitting that bit of code. I think by default most of the people run locally using JDK 14 as it is the version required to build Elasticsearch. Final question, I guess it is not possible in forbidden-apis to prevent subclassing? e.g prevent subclassing Deflator class. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
