uschindler commented on pull request #1849: URL: https://github.com/apache/lucene-solr/pull/1849#issuecomment-690102497
> I have a go locally and It does not seem to work. Tht's what I expected. If they would have used `MethodHandles.lookup()` it would have worked better without `AccessController`. Thanks!!! > Final question, I guess it is not possible in forbidden-apis to prevent subclassing? e.g prevent subclassing Deflator class. No, you can't. There are some way to do this for abstract classes, if you put the constructor on forbiddenapis (as it's called by subclasses). For the use case here it won't work, as we have to call ctor to create the instance. Thanks for the response to all other comments. Sorry for the issue, I was a bit harsh! I will now merge the other PR. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
