[
https://issues.apache.org/jira/browse/LUCENE-9856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17306290#comment-17306290
]
Robert Muir commented on LUCENE-9856:
-------------------------------------
{quote}
This aside, maybe we should return to the idea of the generated code living in
a separate source set?... one that is not subject to formatting, extra
validations, etc? I see some benefit in keeping it neat but it's also, you
know, generated code...
{quote}
Personally I don't know the implications of this, it seems a bit difficult for
my weak gradle kung-fu skills. On the other hand implementing the
properties-based stuff, following Tomoko's lead for the per-module javadocs
options, that's something i might be able to help with.
The problem is not just the generated code: there are 140 or some violations
for just this one simple check. In general, enabling any check is a large
effort if we want to fix 100% of the codebase. So if we can iterate per-module
and fix them incrementally, we make progess.
> Improve static analysis to catch dead code and other potential bugs
> -------------------------------------------------------------------
>
> Key: LUCENE-9856
> URL: https://issues.apache.org/jira/browse/LUCENE-9856
> Project: Lucene - Core
> Issue Type: Improvement
> Components: general/build
> Reporter: Zach Chen
> Priority: Minor
> Labels: build
> Attachments: LUCENE-9856.patch
>
>
> When working on PR [https://github.com/apache/lucene/pull/25,] we noticed
> that some dead code is not being caught during static analysis in gradle
> build, such as the *start* variable in the following code:
> [https://github.com/apache/lucene/blob/a5996dbecd4a6b4147d961260711a2cb6aeab3d3/lucene/facet/src/java/org/apache/lucene/facet/FacetsConfig.java#L446-L456]
>
> We may need to look at if additional javac compiler flag, or configuration
> for *error prone,* should be added to catch such bug as well as other
> potential ones.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
