[ 
https://issues.apache.org/jira/browse/LUCENE-9856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17306624#comment-17306624
 ] 

ASF subversion and git services commented on LUCENE-9856:
---------------------------------------------------------

Commit e14a679e908bdb34eb4c677c11b8d0d60ba05dc3 in lucene's branch 
refs/heads/jira/LUCENE-9856-static-analysis from Robert Muir
[ https://gitbox.apache.org/repos/asf?p=lucene.git;h=e14a679 ]

LUCENE-9856: remove more unused local variables

This fixes all the instances, except for the ones in generated code.


> Improve static analysis to catch dead code and other potential bugs
> -------------------------------------------------------------------
>
>                 Key: LUCENE-9856
>                 URL: https://issues.apache.org/jira/browse/LUCENE-9856
>             Project: Lucene - Core
>          Issue Type: Improvement
>          Components: general/build
>            Reporter: Zach Chen
>            Priority: Minor
>              Labels: build
>         Attachments: LUCENE-9856.patch
>
>
> When working on PR [https://github.com/apache/lucene/pull/25,] we noticed 
> that some dead code is not being caught during static analysis in gradle 
> build, such as the *start* variable in the following code: 
> [https://github.com/apache/lucene/blob/a5996dbecd4a6b4147d961260711a2cb6aeab3d3/lucene/facet/src/java/org/apache/lucene/facet/FacetsConfig.java#L446-L456]
>  
> We may need to look at if additional javac compiler flag, or configuration 
> for *error prone,* should be added to catch such bug as well as other 
> potential ones.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

Reply via email to