gautamworah96 opened a new pull request #191: URL: https://github.com/apache/lucene/pull/191
Additionally, minor method name and variable refactoring in the TestLongValueFacetCounts class (The name `valueCount` was a bit misleading because it was actually representing the number of test docs. The name `testRandom` was a bit too generic for a method that only tested single valued fields.) <!-- _(If you are a project committer then you may remove some/all of the following template.)_ Before creating a pull request, please file an issue in the ASF Jira system for Lucene: * https://issues.apache.org/jira/projects/LUCENE You will need to create an account in Jira in order to create an issue. The title of the PR should reference the Jira issue number in the form: * LUCENE-####: <short description of problem or changes> LUCENE must be fully capitalized. A short description helps people scanning pull requests for items they can work on. Properly referencing the issue in the title ensures that Jira is correctly updated with code review comments and commits. --> # Description Ideally, if a document contains duplicate values, they should only be counted once when you ask for the number of times a value has occurred in the index. So if a doc has the value `2` indexed twice, it should only be counted once when you try to count the number of times the value `2` has occurred using `LongValueFacetCounts` # Solution Added a `uniqueLongValues` map per doc that keeps track of unique values that were already accounted for. # Tests Added a new `testDuplicateLongValues` test that adds duplicate `SortedNumericDocValuesField`s to a doc and then checks the count for those duplicate values. Also, modified the randomized test to calculate the correct count. # Checklist Please review the following and check all that apply: - [x] I have reviewed the guidelines for [How to Contribute](https://wiki.apache.org/lucene/HowToContribute) and my code conforms to the standards described there to the best of my ability. - [x] I have created a Jira issue and added the issue ID to my pull request title. - [x] I have given Lucene maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended) - [x] I have developed this patch against the `main` branch. - [x] I have run `./gradlew check`. - [x] I have added tests for my changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
