rmuir commented on a change in pull request #191: URL: https://github.com/apache/lucene/pull/191#discussion_r659661769
########## File path: lucene/facet/src/test/org/apache/lucene/facet/TestLongValueFacetCounts.java ########## @@ -382,19 +383,19 @@ public void testRandomMultiValued() throws Exception { + allSingleValued); } - long[][] values = new long[valueCount][]; - for (int i = 0; i < valueCount; i++) { + Long[][] values = new Long[docCount][]; Review comment: let's please not use boxed types everywhere. I don't think we need sets to deduplicate anyway (similar to the other code) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org