rmuir commented on a change in pull request #191:
URL: https://github.com/apache/lucene/pull/191#discussion_r659660194
##########
File path:
lucene/facet/src/java/org/apache/lucene/facet/LongValueFacetCounts.java
##########
@@ -162,8 +162,14 @@ private void count(String field, List<MatchingDocs>
matchingDocs) throws IOExcep
if (limit > 0) {
totCount++;
}
+ Long previousValue = null;
Review comment:
lets not use boxed Long type here. just initialize `previousValue` to
zero or any other value and change the check to:
```
if (i == 0 || value != previousValue) {
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
