dsmiley commented on a change in pull request #362:
URL: https://github.com/apache/lucene/pull/362#discussion_r724152591
##########
File path:
lucene/highlighter/src/java/org/apache/lucene/search/uhighlight/UnifiedHighlighter.java
##########
@@ -86,7 +86,7 @@
* <li>{@link #getFormatter(String)}: Customize how snippets are formatted.
* </ul>
*
- * <p>This is thread-safe.
+ * <p>This is thread-safe, notwithstanding the setters.
Review comment:
I also am a bit unhappy with this situation. I also think it's a bit
lopsided to have these boolean setters when we have these Flags -- why not just
set the flags? Good idea for a builder. Let's do in a separate issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
