romseygeek commented on a change in pull request #362:
URL: https://github.com/apache/lucene/pull/362#discussion_r723952192
##########
File path:
lucene/highlighter/src/java/org/apache/lucene/search/uhighlight/UnifiedHighlighter.java
##########
@@ -86,7 +86,7 @@
* <li>{@link #getFormatter(String)}: Customize how snippets are formatted.
* </ul>
*
- * <p>This is thread-safe.
+ * <p>This is thread-safe, notwithstanding the setters.
Review comment:
I wonder if we should refactor these setters out into a Builder?
Thread-safe, except when it's not, isn't a great API to have...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
