dsmiley commented on a change in pull request #362:
URL: https://github.com/apache/lucene/pull/362#discussion_r730550959
##########
File path:
lucene/highlighter/src/java/org/apache/lucene/search/uhighlight/UnifiedHighlighter.java
##########
@@ -1168,9 +1174,12 @@ public CacheHelper getReaderCacheHelper() {
/**
* Internally use the {@link Weight#matches(LeafReaderContext, int)} API
for highlighting. It's
- * more accurate to the query, though might not calculate passage
relevancy as well. Use of this
- * flag requires {@link #MULTI_TERM_QUERY} and {@link #PHRASES}. {@link
- * #PASSAGE_RELEVANCY_OVER_SPEED} will be ignored. False by default.
+ * more accurate to the query, and the snippets can be a little different
for phrases because
+ * the whole phrase is marked up instead of each word. The passage
relevancy calculation can be
+ * different (maybe worse?) and it's slower when highlighting many fields.
Use of this flag
+ * requires {@link #MULTI_TERM_QUERY} and {@link #PHRASES}. {@link
+ * #PASSAGE_RELEVANCY_OVER_SPEED} will be ignored. True by default, so
long as the requirements
Review comment:
> According to this line, it looks like WEIGHT_MATCHES is applicable
only when MULTI_TERM_QUERY and PHRASES are enabled. And it does not matter if
PASSAGE_RELEVANCY_OVER_SPEED enabled or not. Is my understanding correct?
Yes
> I am asking this since I can see that by default defaultHandleMtq,
defaultHighlightPhrasesStrictly and defaultPassageRelevancyOverSpeed are true
which would mean WEIGHT_MATCHES will never be applied based on the logic I had
added.
I don't follow; that seems inverted to me. WEIGHT_MATCHES requires those
booleans to be true, which they are by default, and so WEIGHT_MATCHES will be
enabled by default now.
> Is PASSAGE_RELEVANCY_OVER_SPEED supposed to be marked as false by default?
No; should be true. This lines up with defaultPassageRelevancyOverSpeed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
