[
https://issues.apache.org/jira/browse/LUCENE-9997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17427492#comment-17427492
]
Dawid Weiss commented on LUCENE-9997:
-------------------------------------
Yep, these sanity checks are needed without a doubt. And some of them will be
easier to implement in Python than in Java. Others could be implemented in Java
and run as plain tests on the release folder/ zip - I've done it before and it
works quite well.
bq. because our PRs don't simply run the tests for me
Oh, indeed.
https://github.com/apache/lucene/blob/main/.github/workflows/gradle-precommit.yml#L38-L39
Maybe we should just enable a separate (concurrent) job that just runs the
tests? Not sure how long they'll take on github infrastructure but I think they
should fit the timeout limit?
> Revisit smoketester for 9.0 build
> ---------------------------------
>
> Key: LUCENE-9997
> URL: https://issues.apache.org/jira/browse/LUCENE-9997
> Project: Lucene - Core
> Issue Type: Sub-task
> Reporter: Robert Muir
> Priority: Major
> Time Spent: 1h 50m
> Remaining Estimate: 0h
>
> Currently we have a (great) {{dev-tools/scripts/smokeTester.py}} that will
> perform automated tests against a release.
> This was developed with the ant build process in mind.
> This issue is just about considering the automated checks we do here, maybe
> some of them can be done efficiently in the gradle build in earlier places:
> this would be a large improvement!
> Obviously some of them (e.g. GPG release key verifications) are really
> specific to the artifacts in question. These are most important to release
> verification, as that is actually the only place we can check it.
> Any other checks (and I do tend to think, this checker should try to be
> thorough, invoking gradle etc), should be stuff we regularly test in
> PRs/nightly/builds.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
