[ 
https://issues.apache.org/jira/browse/LUCENE-9997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17428781#comment-17428781
 ] 

Jan Høydahl commented on LUCENE-9997:
-------------------------------------

{quote}I'm sorry I don't fully understand your intention here. In my 
understanding, the smoketester calls "gradlew check", and the 
"checkBrokenLinks" task (it's a wrapper for "checkJavadocLinks.py") is called 
from the "check" task. So the javadoc links are also checked in 9.0 smeketester 
as before?
{quote}
The checkJavadocLins.py script is gone as of LUCENE-9215 and that's why I 
commented out the checkBokenLinks from smoketester, believing that those tests 
now run as part of the regular "gradle check". But that may not be the case - 
can you shed some light on this [~rcmuir] ?

> Revisit smoketester for 9.0 build
> ---------------------------------
>
>                 Key: LUCENE-9997
>                 URL: https://issues.apache.org/jira/browse/LUCENE-9997
>             Project: Lucene - Core
>          Issue Type: Sub-task
>            Reporter: Robert Muir
>            Priority: Major
>         Attachments: image-2021-10-12-12-47-11-480.png, 
> image-2021-10-12-12-48-15-373.png
>
>          Time Spent: 4h 10m
>  Remaining Estimate: 0h
>
> Currently we have a (great) {{dev-tools/scripts/smokeTester.py}} that will 
> perform automated tests against a release.
> This was developed with the ant build process in mind.
> This issue is just about considering the automated checks we do here, maybe 
> some of them can be done efficiently in the gradle build in earlier places: 
> this would be a large improvement!
> Obviously some of them (e.g. GPG release key verifications) are really 
> specific to the artifacts in question. These are most important to release 
> verification, as that is actually the only place we can check it.
> Any other checks (and I do tend to think, this checker should try to be 
> thorough, invoking gradle etc), should be stuff we regularly test in 
> PRs/nightly/builds.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

Reply via email to