[
https://issues.apache.org/jira/browse/LUCENE-9997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17428771#comment-17428771
]
Tomoko Uchida commented on LUCENE-9997:
---------------------------------------
Thanks, Jan, for your feedback.
I understand the smoketester has definitely different perspectives/purposes
from daily tests/checks. On the other hand, to me, gradle (groovy, java) is a
generic tool and I think it also works well as a framework for verifications on
the result of the whole build just like Python, if the tasks are properly
written. So I thought for some (not all) verifications we could run the same
check on the artifacts at both phases - daily tests/checks and pre-release
final verification. But yes, we can implement duplicated checks: ones for
gradle build, one for the smokechecker.
{quote}bq. I think the smoketester in 8.x checks the javadocs links, but not in
9.x
{quote}
I'm sorry I don't fully understand your intention here. In my understanding,
the smoketester calls "gradlew check", and the "checkBrokenLinks" task (it's a
wrapper for "checkJavadocLinks.py") is called from the "check" task. So the
javadoc links are also checked in 9.0 smeketester as before?
> Revisit smoketester for 9.0 build
> ---------------------------------
>
> Key: LUCENE-9997
> URL: https://issues.apache.org/jira/browse/LUCENE-9997
> Project: Lucene - Core
> Issue Type: Sub-task
> Reporter: Robert Muir
> Priority: Major
> Attachments: image-2021-10-12-12-47-11-480.png,
> image-2021-10-12-12-48-15-373.png
>
> Time Spent: 4h 10m
> Remaining Estimate: 0h
>
> Currently we have a (great) {{dev-tools/scripts/smokeTester.py}} that will
> perform automated tests against a release.
> This was developed with the ant build process in mind.
> This issue is just about considering the automated checks we do here, maybe
> some of them can be done efficiently in the gradle build in earlier places:
> this would be a large improvement!
> Obviously some of them (e.g. GPG release key verifications) are really
> specific to the artifacts in question. These are most important to release
> verification, as that is actually the only place we can check it.
> Any other checks (and I do tend to think, this checker should try to be
> thorough, invoking gradle etc), should be stuff we regularly test in
> PRs/nightly/builds.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
