mocobeta commented on pull request #638: URL: https://github.com/apache/lucene/pull/638#issuecomment-1028736869
Hi @uschindler, I think I need your review or opinion. This reduces code duplication and technically works, but adds "open" directives in the module descriptors. If this approach is not preferable, I'll back the dictionary loader utility to both kuromoji and nori - we'll need to maintain two dictionary loaders as before though, I think the code was simplified by the refactoring here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
