uschindler commented on pull request #638: URL: https://github.com/apache/lucene/pull/638#issuecomment-1028808508
I would really not move this dictionary code to commons module and add opens. This is as bad as having the (now deprecated) methods in IOUtils to load stopwords files. Loading of a class resource must always be done by the class itsself not delegated to somebody else - because it is caller-sensitive! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
