mocobeta edited a comment on pull request #638: URL: https://github.com/apache/lucene/pull/638#issuecomment-1028811056
Personally, I don't care about the API or two-args constructor to load external resources (the main interest/concern here) too, but I know there are people who need and add the feature to kuromoji and nori (I forgot the issue). To completely get rid of the methods for loading external resources, we'd need to work on LUCENE-8816. But we seem to have a long way to go. > I would really not move this dictionary code to commons module and add opens. Sure, yes - I understood your intention. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org