alessandrobenedetti commented on code in PR #926:
URL: https://github.com/apache/lucene/pull/926#discussion_r883687821
##########
lucene/core/src/java/org/apache/lucene/util/hnsw/NeighborQueue.java:
##########
@@ -56,9 +56,9 @@ long apply(long v) {
// Whether the search stopped early because it reached the visited nodes
limit
private boolean incomplete;
- public NeighborQueue(int initialSize, boolean reversed) {
+ public NeighborQueue(int initialSize, boolean descOrder) {
Review Comment:
I originally called it "maxHeap" in a previous commit and then moved to
"descOrder" to be in line with the NeighborArray constructor.
A feedback I had from a colleague of mine was:
"externally I may be interested only in building it specifying descOrder or
ascOrder, then internally and per debug purposes this is mapped to MIN_HEAP or
MAX_HEAP"
But anyway, if you/community believes it is better "maxHeap" I'll revert
that bit!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
