alessandrobenedetti commented on code in PR #926:
URL: https://github.com/apache/lucene/pull/926#discussion_r883956772
##########
lucene/core/src/java/org/apache/lucene/util/hnsw/HnswGraphBuilder.java:
##########
@@ -245,11 +244,11 @@ private boolean diversityCheck(
NeighborArray neighbors,
RandomAccessVectorValues vectorValues)
throws IOException {
- bound.set(score);
+ minAcceptedSimilarity = score;
Review Comment:
I was initially using it, but I noticed the BoundChecker was global, so I
thought using the min check locally could cause bugs, if you are sure local is
just fine I'll do that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
