alessandrobenedetti commented on code in PR #926:
URL: https://github.com/apache/lucene/pull/926#discussion_r883689413
##########
lucene/core/src/java/org/apache/lucene/util/hnsw/NeighborQueue.java:
##########
@@ -109,12 +117,15 @@ public int[] nodes() {
/** Returns the top element's node id. */
public int topNode() {
- return (int) order.apply(heap.top());
+ return decodeNodeId(heap.top());
}
- /** Returns the top element's node score. */
- public float topScore() {
- return NumericUtils.sortableIntToFloat((int) (order.apply(heap.top()) >>
32));
+ /**
+ * Returns the top element's node score. For the min heap this is the
minimum score. For the max
Review Comment:
maybe, but when i read topScore, I always think "maxScore", but actually it
is the topNode score, which means min or max depending on the heap.
My preference is to rename it to topNodeScore, but it's not a super-strong
blocking opinion :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
