javanna commented on code in PR #12799:
URL: https://github.com/apache/lucene/pull/12799#discussion_r1399178223
##########
lucene/core/src/java/org/apache/lucene/util/hnsw/ConcurrentHnswMerger.java:
##########
@@ -41,7 +42,7 @@ public ConcurrentHnswMerger(
ExecutorService exec,
int numWorker) {
super(fieldInfo, scorerSupplier, M, beamWidth);
- this.exec = exec;
+ this.taskExecutor = new TaskExecutor(exec);
Review Comment:
Sorry for being picky :) this is good, but I think we can take a
TaskExecutor here that gets created by the caller? Does that make sense?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
