javanna commented on code in PR #12799:
URL: https://github.com/apache/lucene/pull/12799#discussion_r1400536223
##########
lucene/core/src/java/org/apache/lucene/codecs/lucene99/Lucene99HnswVectorsFormat.java:
##########
@@ -160,12 +160,12 @@ public Lucene99HnswVectorsFormat(int maxConn, int
beamWidth) {
* @param maxConn the maximum number of connections to a node in the HNSW
graph
* @param beamWidth the size of the queue maintained during graph
construction.
* @param numMergeWorkers number of workers (threads) that will be used when
doing merge. If
- * larger than 1, a non-null {@link ExecutorService} must be passed as
mergeExec
- * @param mergeExec the {@link ExecutorService} that will be used by ALL
vector writers that are
+ * larger than 1, a non-null {@link TaskExecutor} must be passed as
mergeExec
+ * @param mergeExec the {@link TaskExecutor} that will be used by ALL vector
writers that are
* generated by this format to do the merge
*/
public Lucene99HnswVectorsFormat(
- int maxConn, int beamWidth, int numMergeWorkers, ExecutorService
mergeExec) {
+ int maxConn, int beamWidth, int numMergeWorkers, TaskExecutor mergeExec)
{
Review Comment:
Thanks for voicing your opinion. My main goal was to create one instance of
TaskExecutor per Executor, hence create it as soon as possible. I also believe
that we will want to extend TaskExecutor's capabilities instead of relying on
executor service capabilities in specific places. The idea would be that we use
TaskExecutor for general task execution, and that is used in different places
like query rewrite, search against slices, loading of terms statistics, and now
also building the graph.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
