shubhamvishu commented on code in PR #12799:
URL: https://github.com/apache/lucene/pull/12799#discussion_r1399670946
##########
lucene/core/src/java/org/apache/lucene/codecs/lucene99/Lucene99HnswVectorsWriter.java:
##########
@@ -489,8 +490,9 @@ private void writeMeta(
private HnswGraphMerger createGraphMerger(
FieldInfo fieldInfo, RandomVectorScorerSupplier scorerSupplier) {
if (mergeExec != null) {
+ TaskExecutor taskExecutor = new TaskExecutor(mergeExec);
Review Comment:
Hmm....so I think the way would be to not have ExecutorService and let the
caller pass the TE itself. For that we should give more up in the hierarchy to
have a TE and not ExecutorService. i.e. `Lucene99HnswVectorsFormat`. Does that
sound good?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
