mikemccand commented on code in PR #13364:
URL: https://github.com/apache/lucene/pull/13364#discussion_r1599076213
##########
lucene/core/src/java/org/apache/lucene/codecs/lucene99/Lucene99PostingsReader.java:
##########
@@ -902,6 +917,12 @@ public int advance(int target) throws IOException {
payloadByteUpto = skipper.getPayloadByteUpto();
}
nextSkipDoc = skipper.getNextSkipDoc();
+ } else {
+ // We don't need skip data yet, but we have evidence that advance() is
used, so prefetch it
+ // in the background.
+ if (prefetchedSkipData == false) {
+ prefetchSkipData(docIn, docTermStartFP, skipOffset);
+ }
Review Comment:
Should you set `prefetchedSkipData = true` in here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
