jpountz commented on code in PR #13364:
URL: https://github.com/apache/lucene/pull/13364#discussion_r1599496612
##########
lucene/core/src/java/org/apache/lucene/codecs/lucene99/Lucene99PostingsReader.java:
##########
@@ -1097,7 +1118,9 @@ public BlockImpactsDocsEnum(FieldInfo fieldInfo,
IntBlockTermState termState)
this.docIn = Lucene99PostingsReader.this.docIn.clone();
docFreq = termState.docFreq;
- docIn.seek(termState.docStartFP);
+ seekAndPrefetchPostings(docIn, termState);
+ // Impacts almost certainly need skip data
+ prefetchSkipData(docIn, termState.docStartFP, termState.skipOffset);
Review Comment:
No need here since we're calling it in `reset()` which is only called once
per postings enum. We only track `prefetchedSkipData` in `PostingsEnum` impls
where the prefetching is done as part of `advance()`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
