mikemccand commented on PR #13364: URL: https://github.com/apache/lucene/pull/13364#issuecomment-2108796478
This is cool! In the hot case, do we expect `prefetch` to be a no-op? So we are hoping for "first do no harm" in that case? (I haven't looked at `MMapDirectory`'s impl yet). But in the cold case, this could cause multiple prefetch calls within one segment if the query has multiple terms. And if cross-segment concurrency is enabled, multiple such calls across slices (thread work units) too. But in the cold case this may be a big win? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
