msokolov commented on code in PR #13469:
URL: https://github.com/apache/lucene/pull/13469#discussion_r1632032521
##########
lucene/core/src/java/org/apache/lucene/codecs/lucene99/Lucene99FlatVectorsReader.java:
##########
@@ -217,6 +220,18 @@ public ByteVectorValues getByteVectorValues(String field)
throws IOException {
vectorData);
}
+ @Override
+ public void search(String field, float[] target, KnnCollector knnCollector,
Bits acceptDocs) throws IOException {
Review Comment:
Yes, of course, OK. So I think this will work like this if I leave the
search() methods as throwing UnsupportedOperationException, then use
PerFieldKnnVectorValues to tie a field to a
Lucene99ScalarQuantizedVectorsFormat, at which point I can call
getFloatVectorValues and use the returned scorer's score() method. Or perhaps
call getQuantizedVectorValues directly and use *its* score method. I'll give it
a try.
I'm OK with all that. If this becomes popular we might want to find a way
that doesn't require using codec-specific classes, but we can let that sit for
now I think. Thank you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
